Skip to content

Download the correct tools for Windows 64-bit #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2023
Merged

Download the correct tools for Windows 64-bit #813

merged 5 commits into from
Aug 30, 2023

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Aug 22, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    Bug fix
  • What is the current behavior?
    Tools for Windows 32-bit are downloaded when the OS/Arch is Windows 64-bit.
  • What is the new behavior?
    The correct tools are downloaded for Windows 64-bit.
  • Does this PR introduce a breaking change?
    No

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 22, 2023
@MatteoPologruto MatteoPologruto self-assigned this Aug 22, 2023
@MatteoPologruto MatteoPologruto linked an issue Aug 22, 2023 that may be closed by this pull request
Agent download tools for Windows 32-bit instead of 64-bit #812
Closed
3 tasks
cmaglie
cmaglie requested changes Aug 22, 2023
View reviewed changes
@umbynos umbynos added the os: windows Specific to Windows operating system label Aug 23, 2023
umbynos
umbynos suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the tests.
Did you have the chance of running the agent and see if this fix works?

@umbynos
Copy link
Contributor

umbynos commented Aug 23, 2023

Also I would aim to remove completely the smetrics.Jaro(...) approach in favour of the CLI one:

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.17% 🎉

Comparison is base (d170a5e) 10.96% compared to head (7ec5105) 11.14%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   10.96%   11.14%   +0.17%     
==========================================
  Files          55       53       -2     
  Lines        4066     4073       +7     
==========================================
+ Hits          446      454       +8     
+ Misses       3565     3563       -2     
- Partials       55       56       +1
Flag Coverage Δ
unit 11.14% <75.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tools/download.go 29.44% <60.00%> (-1.19%) ⬇️
v2/pkgs/pkgs.go 75.43% <75.43%> (ø)
v2/pkgs/tools.go 66.44% <100.00%> (-3.91%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto merged commit 75698ba into arduino:main Aug 30, 2023
@MatteoPologruto MatteoPologruto deleted the download-tools-win64 branch August 30, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@umbynos umbynos umbynos approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
os: windows Specific to Windows operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent download tools for Windows 32-bit instead of 64-bit
4 participants
@MatteoPologruto @umbynos @codecov-commenter @cmaglie